search

xmartlabs / XLForm

XLForm is the most flexible and powerful iOS library to create dynamic table-view forms. Fully compatible with Swift & Obj-C.
MIT License
5.77k stars 953 forks source link

Inconsistent highlight / unhighlight colors for XLFormRowDescriptorTypeText vs XLFormRowDescriptorTypeSelectorPickerView #1008

Open jsm174 opened 6 years ago

jsm174 commented 6 years ago

I maybe missing something, but it seems the highlight / unhighlight colors are inconsistent.

For XLFormRowDescriptorTypeText, when activated the title becomes the tint color, while the text field becomes black.

For XLFormRowDescriptorTypeSelectorPickerView, when activated, the title stays black while the value turns to the tint color.

Is this behavior expected?

mats-claassen commented 6 years ago

All the text rows highlight the title and all the selector rows highlight the value. They are different types of rows. The selector rows have been designed the same as the rows in some iOS apps. Text rows normally don't have coloring but I think it did make more sense to highlight the title than the changing text field.