When using @xmartlabs/react-native-line on my project, my client requires that there are separate LINE channels for their separate corporations. So after some time digging in the source code, I found a way to use dynamic channel ID by export the LoginManager.setup method to React Native. I thought that this might be a good feature for the SDK so I created this PR. The coding might be not perfect since this is the first time I try to code on Kotlin and Swift, so recommendations are very appreciated!
:movie_camera: Screen record:
Add a screen record of the execution of your functionality. This way the reviewer can better understand what has been added.
:pushpin: Notes:
Need a code review for the convention I used
:heavy_check_mark:Tasks:
:warning: Warnings:
If the login method gets called before the configure method, the app will crash
PR Title
🔄 Type of change:
:pencil2: Description:
When using
@xmartlabs/react-native-line
on my project, my client requires that there are separate LINE channels for their separate corporations. So after some time digging in the source code, I found a way to use dynamic channel ID by export theLoginManager.setup
method to React Native. I thought that this might be a good feature for the SDK so I created this PR. The coding might be not perfect since this is the first time I try to code on Kotlin and Swift, so recommendations are very appreciated!:movie_camera: Screen record:
Add a screen record of the execution of your functionality. This way the reviewer can better understand what has been added.
:pushpin: Notes:
:heavy_check_mark:Tasks:
:warning: Warnings:
login
method gets called before theconfigure
method, the app will crash