Question about cropping randomness

xmeng525 / RealTimeDenoisingNeuralBilateralGrid

[EGSR2020] Real-time Monte Carlo Denoising with the Neural Bilateral Grid

MIT License

66 stars 13 forks source link

Question about cropping randomness #4

Closed swordigo1995 closed 3 years ago

swordigo1995 commented 3 years ago

Hello, Thanks for your great work. I noticed that you sampling image crops in log space along w-axis during making the dataset (dataloader.py, line 203) . What's your motivation about this operation?

Looking forward to your reply.

xmeng525 commented 3 years ago

Hi Haocheng, You are right. The distribution of sampling image crops should be uniform distribution. The current dataLoader uses log-sampling because I was working on some small experiments and I forgot to change it back (I tried to render in log-space so I need to sample in log space). Feel free to change the sampling back to uniform distribution! I will try to update the code in the future. Please let me know if you have any other questions.