xmengli / H-DenseUNet

TMI 2018. H-DenseUNet: Hybrid Densely Connected UNet for Liver and Tumor Segmentation from CT Volumes
527 stars 161 forks source link

Some inconsistencies between the paper and the code. #9

Closed ghost closed 5 years ago

ghost commented 5 years ago

Hi, I read your paper H-DenseUNet: Hybrid Densely Connected UNet for Liver and Tumor Segmentation from CT Volumes and find some inconsistencies between the network structure in your paper and the released code. (1) In the Table I of your paper, the upsampling layers of 2D DenseUNet or 3D DenseUNet is composed of a 2x2 upsampling and a dense block, while in the code, the upsampling layers are composed of a 2x2 upsampling and only one convolution (for example, see the line 154 and line 241 in hybridnet.py). (2) Meanwhile, in your released code, I notice that the UNet-like connections in the 3D DenseUNet are commented out (see the line 153 in hybridnet.py), which is not the same as it in your paper. Could you please help me figure it out?

xmengli commented 5 years ago

For question 1, '-' in table 1 denotes sum connections with the end layer of the dense block. The features are added with each dense block in the encoder part. For question 2, the main contribution of the paper is the hybrid usage of 2D convolution and 3D convolution. The usage of the u-net connection maybe better in the hybrid training. However, for simplicity, the released test model for you to reproduce the results is the one that tested without u-net connection.

ghost commented 5 years ago

OK, Thanks for your help. No offense but it means I can reproduce the results even with this simple version of H-DenseUNet, right?

xmengli commented 5 years ago

exactly

ghost commented 5 years ago

Thanks!