setting for general_workday_sunday replaced by workload_of_parent_issues

[ydelgadoplata]

Greetings to all development team. This plugin is amazing! Congrats for the excellent work.

Here's my case. I have set up and configure the plugin, I have defined the Non Working days (as seen in picture), and make the rest of the configuration.

After finishing the configuration, when I visit the workload page, the workload is estimated using the non working day (Sunday/Domingo).

Is there any configuration that I'm missing or what could be the problem? Because if I checked the Sunday as a non working day, it is supposed that the estimation of the workload does not count on working days.

Thanks

[mboremski]

Dear @ydelgadoplata, thank you for your feedback. I am happy to hear that you like the plugin so far.

Your issue is new to me. It looks like you made the right configuration to have weekends not taken into account in workload calculations. I made a look into our configutation and was suprides to see the checkbox for sunday set. I also have not been able to toggle the checkbox for sunday.

Maybe there is some regarding this field. Could you mabe check if you can set this checkbox and if you are able to can you test if may itls logic is tured around?

[ydelgadoplata]

Dear @mboremski, according to your hunch, I tryed this:

1. Try to check the only the sunday and apply the changes. The check for sunday was not checked.

2. I checked the "Include Parents Taks" and suddenly the Sunday check is on and cannot be unselected.

3. If you uncheck the "Include Parent Tasks", the sunday check is uncheck, but cannot be checked.

4. If you only check the "Include Parent Tasks", the check for sunday is on and cannot be uncheked.

5. I have change the parent tasks configuration (see the image), and redo all the tests with the same results. Also notice that I have configured that Saturday and Sunday are not Working days.

Glad to help. Let me know your findings.

[mboremski]

Thanks @ydelgadoplata ! I had a deeper look on this. It looks like we messed some settings up while we where adding the feature regarding parent_issues

Here https://github.com/xmera-circle/redmine_workload/commit/7cb6773cba8b6c6223358d52e37921944c736f8f we introduced this feature and had to add the ability to configure this. There we changed general_workday_sunday to workload_of_parent_issues but I think we should have added the config instead.

As said, I can confirm this issue in my testsystem. Unfortunately I am not able to get the old config back where sunday was a not a working day.

Maybe you can use holidays for sundays until we fix this? (not able to test if this works)

@liaham, could you have a look on this?

[ydelgadoplata]

Thanks a lot @mboremski.

I have tested defining the sunday as a holiday and it works.

But it's quite annoying to create remaining Sundays (just over 20) as holidays.

But that's ok, I'll do it this way for now, while you could find the solution.

Thanks for the support!

[liaham]

Thank you all for reporting and investigating this issue!

I fixed the plugin settings. But now I can into other issues when testing. So fixing is not that quick as it seemed. Might take a while.

[liaham]

The problem should be fixed now. The develop - branch passes all tests.

@ydelgadoplata, if you like you can use the develop branch until we release the next version by end of July.

[mboremski]

@ydelgadoplata mentioned the settings for workdays in redmine-core (under tickets).

Yust wanted to share my thoutght and ask for your opinion: Maybe we should remove the workday-setting from our plugin and get the data from the setting in redmine-core?

[ydelgadoplata]

Thanks @liaham. I've already set the sundays as holidays and I'll be able to wait until the next release. Also, I have a suggestion for a new functionality (will be created later on), if it's possible for you to take a look on it.

@mboremski in my opinion, it would be interesting for us (as Project Managers), to have the visual impact based on "what if"... As an example, you can check if you plan to work for weekends or not if the workload is still high. I don't know if this sentence makes any sense to you.

[mboremski]

This issue will be closed on the next release.

@ydelgadoplata, please create a new issue where we can discuss your suggestions. Thank you. 😃