search

xmidt-org / ancla

Ancla provides event webhook registry capabilities to XMiDT services.
Apache License 2.0
1 stars 2 forks source link

Post Argus Webhook fields in question... #15

Open joe94 opened 4 years ago

joe94 commented 4 years ago

Once we switch to Argus, webhook expirations will be driven by Argus' TTL of the entries in its database.

This is making me question the precise role of fields such as Until and especially Duration Source: https://github.com/xmidt-org/webpa-common/blob/main/webhook/webhook.go#L55

For Duration: we're always setting this value to 5 mins and I don't really see it being used except for times when Until is not defined.

For Until: I can see this field being a more immediate way for caduceus to know whether to keep sending events or not to a subscriber. However, the list of subscribers will be eventually refreshed through Argus anyways.

kristinapathak commented 4 years ago

I remember discussing the Argus TTL when planning Mimisbrunnr, and there was a real reason that we kept ExpiresAt in the object stored with Argus... https://github.com/xmidt-org/mimisbrunnr/blob/main/model/model.go#L29

I don't remember the specifics, so I can look into it more and see if I can remember/find those details.