search

xmidt-org / argus

simple json database abstraction layer
Apache License 2.0
3 stars 9 forks source link

Add optional OpenTelemetry tracing #165

Closed joe94 closed 3 years ago

joe94 commented 3 years ago

We should try and stay consistent with how the feature is configured and set up. Here's an example from Tr1d1um: https://github.com/xmidt-org/tr1d1um/issues/203

Since Argus and Themis are both using the uber/fx lib, they're likely to share more in common.

joe94 commented 3 years ago

A version of Themis with instrumentation has been published. https://github.com/xmidt-org/themis/issues/74 contains the implementation details that we should follow for Argus.

utsavbatra5 commented 3 years ago

Hi @joe94 I have opened a PR for argus https://github.com/xmidt-org/argus/pull/170

joe94 commented 3 years ago

Fixed in #170

Sachin4403 commented 3 years ago

HI @joe94

When you guys are planning to release the argus version with automatic instrumentation of candlelight?

joe94 commented 3 years ago

@Sachin4403, I was hoping to merge a fix to the bug you guys reported yesterday (https://github.com/xmidt-org/argus/pull/171) and then releasing. Are you guys blocked by that bug or can you move forward with it? If my fix will take longer than today and it's not a blocker to you, I will go ahead and make a release.

Sachin4403 commented 3 years ago

@joe94, We were blocked on that but now we are continuing with DB, so we unblocked now. It will be helpful if you can release argus.

joe94 commented 3 years ago

@Sachin4403, sounds good. I'll release it ASAP today.

Sachin4403 commented 3 years ago

Thanks @joe94 for releasing argus/v0.3.15