xmidt-org / bascule

Provides authentication and authorization workflows
Apache License 2.0
2 stars 4 forks source link

Feature/v1 #243

Closed johnabass closed 6 months ago

johnabass commented 6 months ago

Alpha version of the redesign

guardrails[bot] commented 6 months ago

:warning: We detected 1 security issue in this pull request:

Vulnerable Libraries (1)
Severity | Details :-: | :-- High | [pkg:golang/github.com/lestrrat-go/jwx/v2@v2.0.20](https://github.com/xmidt-org/bascule/blob/b5181a5a8acd1c03494a2129244dfe718bfc2018/go.mod#L6) upgrade to: *> v2.0.20* More info on how to fix Vulnerable Libraries in [Go](https://docs.guardrails.io/docs/en/vulnerabilities/go/using_vulnerable_libraries.html?utm_source=ghpr).

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 32.90488% with 261 lines in your changes are missing coverage. Please review.

Project coverage is 32.02%. Comparing base (2a6591f) to head (b5181a5). Report is 15 commits behind head on main.

Files Patch % Lines
basculehttp/middleware.go 0.00% 133 Missing :warning:
basculehttp/error.go 0.00% 37 Missing :warning:
basculehttp/accessor.go 0.00% 33 Missing :warning:
basculehttp/basic.go 0.00% 29 Missing :warning:
basculejwt/token.go 0.00% 17 Missing :warning:
basculehttp/challenge.go 0.00% 6 Missing :warning:
basculehttp/token.go 0.00% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #243 +/- ## =========================================== - Coverage 85.56% 32.02% -53.54% =========================================== Files 36 14 -22 Lines 1482 434 -1048 =========================================== - Hits 1268 139 -1129 - Misses 196 295 +99 + Partials 18 0 -18 ``` | [Flag](https://app.codecov.io/gh/xmidt-org/bascule/pull/243/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xmidt-org) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/xmidt-org/bascule/pull/243/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xmidt-org) | `32.02% <32.90%> (-53.54%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xmidt-org#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.