xmidt-org / bascule

Provides authentication and authorization workflows
Apache License 2.0
2 stars 4 forks source link

Feature/allow source in validators #271

Closed johnabass closed 3 months ago

johnabass commented 3 months ago

A validation refactoring that allows much more flexible and simpler validation code.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 97.43590% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.32%. Comparing base (85e0935) to head (3336041). Report is 27 commits behind head on main.

Files Patch % Lines
basculehttp/middleware.go 57.14% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #271 +/- ## =========================================== + Coverage 32.74% 67.32% +34.58% =========================================== Files 15 14 -1 Lines 452 456 +4 =========================================== + Hits 148 307 +159 + Misses 304 141 -163 - Partials 0 8 +8 ``` | [Flag](https://app.codecov.io/gh/xmidt-org/bascule/pull/271/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xmidt-org) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/xmidt-org/bascule/pull/271/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xmidt-org) | `67.32% <97.43%> (+34.58%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xmidt-org#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.