xmidt-org / caduceus

The Xmidt server for delivering events written in Go.
Apache License 2.0
16 stars 19 forks source link

Remove Ancla Dependecies from whole package and Bascule Dependencies from fx portion of app #432

Closed maurafortino closed 7 months ago

maurafortino commented 8 months ago

What's Included:

PR https://github.com/xmidt-org/caduceus/pull/433 should be merged first

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (denopink/feat/rewrite@e04baf4). Click here to learn what that means.

:exclamation: Current head 28b0b22 differs from pull request most recent head 5242d5f. Consider uploading reports for the commit 5242d5f to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## denopink/feat/rewrite #432 +/- ## ======================================================== Coverage ? 31.09% ======================================================== Files ? 12 Lines ? 1103 Branches ? 0 ======================================================== Hits ? 343 Misses ? 745 Partials ? 15 ``` | [Flag](https://app.codecov.io/gh/xmidt-org/caduceus/pull/432/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xmidt-org) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/xmidt-org/caduceus/pull/432/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xmidt-org) | `31.09% <0.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xmidt-org#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

guardrails[bot] commented 8 months ago

:warning: We detected 6 security issues in this pull request:

Hard-Coded Secrets (1)
Severity | Details | Docs :-: | :-- | :-: Medium | Title: **Secret Keyword**
https://github.com/xmidt-org/caduceus/blob/5242d5f1ea49909b5fa039da31bf5ef893ee8b90/outboundSender.go#L665 | [:books:](https://docs.guardrails.io/docs/en/vulnerabilities/general/hard-coded_secrets.html?utm_source=ghpr#SecretKeyword) More info on how to fix Hard-Coded Secrets in [General](https://docs.guardrails.io/docs/en/vulnerabilities/general/hard-coded_secrets.html?utm_source=ghpr). ---
Vulnerable Libraries (5)
Severity | Details :-: | :-- N/A | [pkg:golang/github.com/xmidt-org/touchstone@v0.1.2](https://github.com/xmidt-org/caduceus/blob/5242d5f1ea49909b5fa039da31bf5ef893ee8b90/go.mod#L22) - **no patch available** N/A | [pkg:golang/github.com/xmidt-org/webpa-common/v2@v2.1.4](https://github.com/xmidt-org/caduceus/blob/5242d5f1ea49909b5fa039da31bf5ef893ee8b90/go.mod#L23) - **no patch available** N/A | [pkg:golang/github.com/spf13/viper@v1.16.0](https://github.com/xmidt-org/caduceus/blob/5242d5f1ea49909b5fa039da31bf5ef893ee8b90/go.mod#L14) - **no patch available** N/A | [pkg:golang/github.com/xmidt-org/sallust@v0.2.2](https://github.com/xmidt-org/caduceus/blob/5242d5f1ea49909b5fa039da31bf5ef893ee8b90/go.mod#L21) - **no patch available** N/A | [pkg:golang/github.com/stretchr/testify@v1.8.4](https://github.com/xmidt-org/caduceus/blob/5242d5f1ea49909b5fa039da31bf5ef893ee8b90/go.mod#L15) - **no patch available** More info on how to fix Vulnerable Libraries in [Go](https://docs.guardrails.io/docs/en/vulnerabilities/go/using_vulnerable_libraries.html?utm_source=ghpr).

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.