xmidt-org / caduceus

The Xmidt server for delivering events written in Go.
Apache License 2.0
16 stars 19 forks source link

Middleware #435

Closed maurafortino closed 7 months ago

maurafortino commented 7 months ago

What's Included:

guardrails[bot] commented 7 months ago

:warning: We detected 2 security issues in this pull request:

Vulnerable Libraries (2)
Severity | Details :-: | :-- N/A | [pkg:golang/github.com/satori/go.uuid@v1.2.0](https://github.com/xmidt-org/caduceus/blob/0d1e67803e8fa256b290f76f3260b78bde0400e7/go.mod#L12) upgrade to: *1.2.1-0.20181016170032-d91630c85102* N/A | [pkg:golang/github.com/xmidt-org/webpa-common/v2@v2.1.4](https://github.com/xmidt-org/caduceus/blob/0d1e67803e8fa256b290f76f3260b78bde0400e7/go.mod#L23) - **no patch available** More info on how to fix Vulnerable Libraries in [Go](https://docs.guardrails.io/docs/en/vulnerabilities/go/using_vulnerable_libraries.html?utm_source=ghpr).

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

maurafortino commented 7 months ago

besides httpClient_test.go and http_test.go being completely commented out (assuming we're gonna those back in the near future or in this pr), lgtm

yeah had to comment out the test files because they were using functions that were also being commented out due to ancla/argus issue. will comment back in once we get that fixed. @denopink

codecov[bot] commented 7 months ago

Codecov Report

Attention: 52 lines in your changes are missing coverage. Please review.

Comparison is base (28b0b22) 31.09% compared to head (132c6c5) 19.86%. Report is 4 commits behind head on denopink/feat/rewrite.

:exclamation: Current head 132c6c5 differs from pull request most recent head 0d1e678. Consider uploading reports for the commit 0d1e678 to get more accurate results

Files Patch % Lines
http.go 0.00% 37 Missing :warning:
routes.go 0.00% 15 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## denopink/feat/rewrite #435 +/- ## ========================================================== - Coverage 31.09% 19.86% -11.24% ========================================================== Files 12 12 Lines 1103 1148 +45 ========================================================== - Hits 343 228 -115 - Misses 745 908 +163 + Partials 15 12 -3 ``` | [Flag](https://app.codecov.io/gh/xmidt-org/caduceus/pull/435/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xmidt-org) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/xmidt-org/caduceus/pull/435/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xmidt-org) | `19.86% <8.77%> (-11.24%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xmidt-org#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.