xmidt-org / caduceus

The Xmidt server for delivering events written in Go.
Apache License 2.0
16 stars 19 forks source link

Senderwrapper #436

Closed maurafortino closed 7 months ago

maurafortino commented 7 months ago

What's Included:

codecov[bot] commented 7 months ago

Codecov Report

Attention: 164 lines in your changes are missing coverage. Please review.

Comparison is base (132c6c5) 19.86% compared to head (234c7de) 16.78%. Report is 4 commits behind head on denopink/feat/rewrite.

Files Patch % Lines
senderWrapper.go 0.00% 82 Missing :warning:
outboundSender.go 0.00% 43 Missing :warning:
metrics.go 0.00% 24 Missing :warning:
http.go 0.00% 10 Missing :warning:
httpClient.go 0.00% 4 Missing :warning:
routes.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## denopink/feat/rewrite #436 +/- ## ========================================================= - Coverage 19.86% 16.78% -3.08% ========================================================= Files 12 12 Lines 1148 1233 +85 ========================================================= - Hits 228 207 -21 - Misses 908 1014 +106 Partials 12 12 ``` | [Flag](https://app.codecov.io/gh/xmidt-org/caduceus/pull/436/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xmidt-org) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/xmidt-org/caduceus/pull/436/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xmidt-org) | `16.78% <0.00%> (-3.08%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xmidt-org#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

guardrails[bot] commented 7 months ago

:warning: We detected 1 security issue in this pull request:

Insecure Network Communication (1)
Severity | Details | Docs :-: | :-- | :-: Medium | Title: **Insecure SSL/TLS versions allowed**
https://github.com/xmidt-org/caduceus/blob/234c7ded30ec2e90bf35813deea3e8e323e14753/senderWrapper.go#L140 | [:books:](https://docs.guardrails.io/docs/en/vulnerabilities/go/insecure_network_communication.html?utm_source=ghpr#missing-ssl-minversion) More info on how to fix Insecure Network Communication in [Go](https://docs.guardrails.io/docs/en/vulnerabilities/go/insecure_network_communication.html?utm_source=ghpr).

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.