Closed maurafortino closed 7 months ago
Attention: 34 lines
in your changes are missing coverage. Please review.
Comparison is base (
234c7de
) 16.78% compared to head (9ae064c
) 7.99%. Report is 1 commits behind head on denopink/feat/rewrite.:exclamation: Current head 9ae064c differs from pull request most recent head 42dddb0. Consider uploading reports for the commit 42dddb0 to get more accurate results
Files | Patch % | Lines |
---|---|---|
primaryHandler.go | 0.00% | 17 Missing :warning: |
http.go | 0.00% | 9 Missing :warning: |
outboundSender.go | 0.00% | 8 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
lgtm!
at somepoint we'll need to replace viper as well
yeah it's basically gone at this point - it just exists in primaryHandler.go which isn't being used right now - just keeping it so it's easier for me to reference what's needed for bascule once we have new bascule.
going to change the listener stub and add the middleware in in the v2 work
What's Included:
should be reviewed/merged after merging https://github.com/xmidt-org/caduceus/pull/436