search

xmidt-org / caduceus

The Xmidt server for delivering events written in Go.
Apache License 2.0
16 stars 19 forks source link

Clean up #444

Closed maurafortino closed 7 months ago

maurafortino commented 7 months ago

What's Included:

should be reviewed/merged after merging https://github.com/xmidt-org/caduceus/pull/436

guardrails[bot] commented 7 months ago

All previously detected findings have been fixed. Good job! 👍🎉

We will keep this comment up-to-date as you go along and notify you of any security issues that we identify.

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

codecov[bot] commented 7 months ago

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (234c7de) 16.78% compared to head (9ae064c) 7.99%. Report is 1 commits behind head on denopink/feat/rewrite.

:exclamation: Current head 9ae064c differs from pull request most recent head 42dddb0. Consider uploading reports for the commit 42dddb0 to get more accurate results

Files Patch % Lines
primaryHandler.go 0.00% 17 Missing :warning:
http.go 0.00% 9 Missing :warning:
outboundSender.go 0.00% 8 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## denopink/feat/rewrite #444 +/- ## ======================================================== - Coverage 16.78% 7.99% -8.80% ======================================================== Files 12 12 Lines 1233 1214 -19 ======================================================== - Hits 207 97 -110 - Misses 1014 1117 +103 + Partials 12 0 -12 ``` | [Flag](https://app.codecov.io/gh/xmidt-org/caduceus/pull/444/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xmidt-org) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/xmidt-org/caduceus/pull/444/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xmidt-org) | `7.99% <0.00%> (-8.80%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xmidt-org#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

maurafortino commented 7 months ago

lgtm!

at somepoint we'll need to replace viper as well

yeah it's basically gone at this point - it just exists in primaryHandler.go which isn't being used right now - just keeping it so it's easier for me to reference what's needed for bascule once we have new bascule.

maurafortino commented 7 months ago

going to change the listener stub and add the middleware in in the v2 work