xmidt-org / caduceus

The Xmidt server for delivering events written in Go.
Apache License 2.0
16 stars 21 forks source link

Listener interface draft solution v3 #466

Closed maurafortino closed 3 months ago

maurafortino commented 4 months ago

another possible solution - every time I try to make generic it's just doesn't seem worth it? Idk maybe we need to discuss reworking the Update feature as a whole?

guardrails[bot] commented 4 months ago

:warning: We detected 1 security issue in this pull request:

Hard-Coded Secrets (1)
Severity | Details | Docs :-: | :-- | :-: Medium | Title: **Secret Keyword**
https://github.com/xmidt-org/caduceus/blob/ab1afb1101d29ee0fdcbcfc50ba278634c3124a0/sinkInterface.go#L244 | [:books:](https://docs.guardrails.io/docs/en/vulnerabilities/general/hard-coded_secrets.html?utm_source=ghpr#SecretKeyword) More info on how to fix Hard-Coded Secrets in [General](https://docs.guardrails.io/docs/en/vulnerabilities/general/hard-coded_secrets.html?utm_source=ghpr).

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.