search

xmidt-org / cjwt

A c jwt implementation
15 stars 21 forks source link

Correct return codes and eliminiate silent failure #29

Closed schmidtw closed 4 years ago

codecov-io commented 4 years ago

Codecov Report

Merging #29 into master will increase coverage by 0.45%. The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   75.11%   75.56%   +0.45%     
==========================================
  Files           2        2              
  Lines         442      442              
==========================================
+ Hits          332      334       +2     
+ Misses        110      108       -2
Flag Coverage Δ
#unittests 75.56% <84.61%> (+0.45%) :arrow_up:
Impacted Files Coverage Δ
tests/test_cjwt.c 81.48% <66.66%> (ø) :arrow_up:
src/cjwt.c 74.23% <90%> (+0.55%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c68ceb4...ec13808. Read the comment docs.

bill1600 commented 4 years ago

I see we are not accepting algorithm none. In that case, this looks good to mw