search

xmidt-org / codex-deploy

Codex provides a historical context about devices connected to XMiDT.
Apache License 2.0
5 stars 8 forks source link

Update Readme, with heimdall and badge fixes #99

Closed firfircelik closed 4 years ago

firfircelik commented 4 years ago

according to #93

CLAassistant commented 4 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

firfircelik seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

kcajmagic commented 4 years ago

@firfircelik thank you for doing these changes. Can you please sign the CLA so I can merge in this PR.

firfircelik commented 4 years ago

@kcajmagic done

kcajmagic commented 4 years ago

@firfircelik, sorry for the inconvenience it appears that the commits were made are not attached to your github account.

I believe you need to attach your github email to your git config

kristinapathak commented 4 years ago

@firfircelik, Do you need any guidance with how to re-commit your changes with your config set to the correct user.name and user.email? Anything we can help with to get this merged?

firfircelik commented 4 years ago

according to conversation https://github.com/xmidt-org/codex-deploy/issues/95#issuecomment-546841800 I'm passing this issue.

since I done all needed for CLA and result is still same.

kristinapathak commented 4 years ago

The commits you made (here is one: https://github.com/xmidt-org/codex-deploy/pull/99/commits/552aeaa31e60aa3df25be25aa8d49f60973eb59c, you can see it says your username has committed it but the icon is wrong) are not attached to your account. Even though you signed the CLA, the commits themselves are perceived as from a "different user". The most common reason for that is that your email is not attached to your git configuration, so the commits don't have your email in them. That is what Jack was telling you 17 days ago and we tried to help you with.

Since you have given the issue to someone else to fix, I am closing this pull request.