schmidtw commented 3 years ago

It turns out that there are a fair number of verbose logs that need to be printed. It is time to add a printf() style verbose function to elminate a bunch of duplicate checks all over the code.

guardrails[bot] commented 3 years ago

:warning: We detected 1 security issue in this pull request:

Insecure Processing of Data (1)

Docs | Details ----- | -------- [:bulb:](https://docs.guardrails.io/docs/en/vulnerabilities/c/insecure_processing_of_data.html?utm_source=ghpr) | Title: **format**
https://github.com/xmidt-org/curlws/blob/8e4c800beaa866df5bf688d79971d10a6d230a83/src/verbose.c#L60 More info on how to fix Insecure Processing of Data in [C/C++](https://docs.guardrails.io/docs/en/vulnerabilities/c/insecure_processing_of_data.html?utm_source=ghpr).

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

codecov[bot] commented 3 years ago

Codecov Report

Merging #40 (8e4c800) into main (46ad2b0) will increase coverage by 0.34%. The diff coverage is 96.96%.

@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   86.24%   86.59%   +0.34%     
==========================================
  Files          33       34       +1     
  Lines        3330     3305      -25     
==========================================
- Hits         2872     2862      -10     
+ Misses        458      443      -15

Impacted Files	Coverage Δ
src/receive.c	`97.47% <66.66%> (+1.45%)`	:arrow_up:
src/cb.c	`100.00% <100.00%> (ø)`
src/header.c	`100.00% <100.00%> (+6.52%)`	:arrow_up:
src/send.c	`84.28% <100.00%> (+6.65%)`	:arrow_up:
src/verbose.c	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 46ad2b0...8e4c800. Read the comment docs.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

97.5% Coverage
0.0% Duplication

xmidt-org / curlws

Add a verbose function #40

Codecov Report