search

xmidt-org / talaria

The Xmidt routing agent.
Apache License 2.0
11 stars 21 forks source link

patch: eventDispatcher metrics, remove event type label and introduce scheme label #485

Closed denopink closed 1 month ago

denopink commented 1 month ago
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 76.71233% with 17 lines in your changes missing coverage. Please review.

Project coverage is 59.42%. Comparing base (5359d6d) to head (b62d065). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
eventDispatcher.go 82.97% 7 Missing and 1 partial :warning:
metrics.go 64.70% 6 Missing :warning:
workerPool.go 66.66% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #485 +/- ## ========================================== + Coverage 59.15% 59.42% +0.26% ========================================== Files 18 18 Lines 1496 1496 ========================================== + Hits 885 889 +4 + Misses 569 565 -4 Partials 42 42 ``` | [Flag](https://app.codecov.io/gh/xmidt-org/talaria/pull/485/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xmidt-org) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/xmidt-org/talaria/pull/485/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xmidt-org) | `59.42% <76.71%> (+0.26%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xmidt-org#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.