search

xmidt-org / themis

This is a JWT Issuer for the Xmidt service
Apache License 2.0
4 stars 10 forks source link

added certificate chain verification #254

Closed johnabass closed 2 weeks ago

johnabass commented 2 weeks ago

I think this will verify that peer certs are in the root CA chain, which is what's installed locally.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 55.33%. Comparing base (b48cdb2) to head (e0c50d5). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
token/claimBuilder.go 66.66% 4 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #254 +/- ## ========================================== + Coverage 55.25% 55.33% +0.07% ========================================== Files 54 54 Lines 2320 2335 +15 ========================================== + Hits 1282 1292 +10 - Misses 1011 1015 +4 - Partials 27 28 +1 ``` | [Flag](https://app.codecov.io/gh/xmidt-org/themis/pull/254/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xmidt-org) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/xmidt-org/themis/pull/254/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xmidt-org) | `55.33% <66.66%> (+0.07%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xmidt-org#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.