search

xmidt-org / webpa-common

The collection of small common packages for the webpa project.
Apache License 2.0
25 stars 26 forks source link

Updated Metrics for Caduceus #917

Closed maurafortino closed 1 year ago

maurafortino commented 1 year ago

This is part of the webpa-common deprecation.

Added a new function to create a PrometheusGauge for the caduceus. Caduceus will still need the xmetrics package - but will be able to implement the newest version of ancla.

denopink commented 1 year ago

besides the failing tests, lgtm! 🍻

this is likely due to a test timeout

codecov[bot] commented 1 year ago

Codecov Report

Merging #917 (2b2b89f) into main (864d0b5) will decrease coverage by 0.23%. The diff coverage is 5.55%.

@@            Coverage Diff             @@
##             main     #917      +/-   ##
==========================================
- Coverage   82.30%   82.08%   -0.23%     
==========================================
  Files         138      138              
  Lines        8556     8573      +17     
==========================================
- Hits         7042     7037       -5     
- Misses       1321     1344      +23     
+ Partials      193      192       -1
Flag Coverage Δ
unittests 82.08% <5.55%> (-0.23%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
xmetrics/registry.go 84.37% <5.55%> (-8.20%) :arrow_down:

... and 2 files with indirect coverage changes