search

xmidt-org / wrp-go

go implementation of the Web Routing Protocol
Apache License 2.0
4 stars 7 forks source link

dependabot doesn't really work on this repo #113

Open johnabass opened 1 year ago

johnabass commented 1 year ago

We use ugorji's code generation on the various wrp message structs. While this speeds up encoding and decoding, it does mean that we can't just update ugorji without rerunning the code generation. See: https://ugorji.net/blog/go-codecgen, specifically "How do I know if I have to re-generate the code?".

Dependabot, being a general tool, doesn't know anything about this requirement. That means that whenever dependabot thinks ugorji needs an update, all our unit tests for dependabot's PR fail. Example: https://github.com/xmidt-org/wrp-go/pull/112

We should either (1) disable dependabot for this repo, or (2) figure out how to make dependabot smarter.

schmidtw commented 1 year ago

Good catch. I think I'm missing a step during building where everything is regenerated.