search

xmidt-org / wrp-go

go implementation of the Web Routing Protocol
Apache License 2.0
4 stars 7 forks source link

updated getMessageType return to LastMessageType #146

Closed maurafortino closed 7 months ago

maurafortino commented 7 months ago

the MessageTypeValidator function was not working as expected when returning UnknownMessageType from getMessageType. Now returning LastMessageType instead.

Related Story: https://github.com/xmidt-org/wrp-go/issues/143

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c62c675) 47.65% compared to head (21be3d5) 47.65%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #146 +/- ## ======================================= Coverage 47.65% 47.65% ======================================= Files 24 24 Lines 4342 4342 ======================================= Hits 2069 2069 Misses 2083 2083 Partials 190 190 ``` | [Flag](https://app.codecov.io/gh/xmidt-org/wrp-go/pull/146/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xmidt-org) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/xmidt-org/wrp-go/pull/146/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xmidt-org) | `47.65% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xmidt-org#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.