codecov[bot]
commented
3 months ago Codecov Report
Attention: Patch coverage is 0% with 148 lines in your changes are missing coverage. Please review.
Project coverage is 50.10%. Comparing base (
ac04be7) to head (cf93c70). Report is 2 commits behind head on main.
| Files | Patch % | Lines |
|---|---|---|
| wrpcorrectify/options.go | 0.00% | 114 Missing :warning: |
| wrpcorrectify/metrics.go | 0.00% | 21 Missing :warning: |
| wrpcorrectify/correctify.go | 0.00% | 13 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #164 +/- ## ========================================== - Coverage 51.66% 50.10% -1.57% ========================================== Files 31 34 +3 Lines 4746 4894 +148 ========================================== Hits 2452 2452 - Misses 2104 2252 +148 Partials 190 190 ``` | [Flag](https://app.codecov.io/gh/xmidt-org/wrp-go/pull/164/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xmidt-org) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/xmidt-org/wrp-go/pull/164/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xmidt-org) | `50.10% <0.00%> (-1.57%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=xmidt-org#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
schmidtw
This is a code doodle that shows what I'm thinking for the options based validator & normalizer code. I think this should support the metrics use cases we have & probably more if we want.
I would like to chat about this tomorrow if possible.