search

xmidt-org / wrp-go

go implementation of the Web Routing Protocol
Apache License 2.0
4 stars 7 forks source link

Lint fixes #59

Closed kristinapathak closed 3 years ago

kristinapathak commented 3 years ago

Not sure how to fix the last remaining lint issue:

format.go:41:16: SA1019: codec.BasicHandle is deprecated: DO NOT USE DIRECTLY. EXPORTED FOR GODOC BENEFIT. WILL BE REMOVED.  (staticcheck)
        BasicHandle: codec.BasicHandle{
                     ^
format.go:52:16: SA1019: codec.BasicHandle is deprecated: DO NOT USE DIRECTLY. EXPORTED FOR GODOC BENEFIT. WILL BE REMOVED.  (staticcheck)
        BasicHandle: codec.BasicHandle{
                     ^
codecov[bot] commented 3 years ago

Codecov Report

Merging #59 (05ec5c8) into main (e4a7519) will increase coverage by 0.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   44.48%   44.52%   +0.03%     
==========================================
  Files          15       15              
  Lines        2958     2960       +2     
==========================================
+ Hits         1316     1318       +2     
  Misses       1480     1480              
  Partials      162      162
Impacted Files Coverage Δ
wrphttp/requestResponse.go 94.73% <ø> (ø)
wrphttp/headers.go 95.68% <100.00%> (+0.06%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e4a7519...05ec5c8. Read the comment docs.

sonarcloud[bot] commented 3 years ago

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication