search

xmidt-org / wrp-go

go implementation of the Web Routing Protocol
Apache License 2.0
4 stars 7 forks source link

metadata builder changes for missing fields #79

Closed dhruv-bansal closed 2 years ago

dhruv-bansal commented 2 years ago

first, pull a request for a fix - https://github.com/xmidt-org/talaria/issues/186

CC @schmidtw

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

Sachin4403 commented 2 years ago

Hello Team,

Once this PR is merged we need to upgrade this module version in talaria.

codecov[bot] commented 2 years ago

Codecov Report

Merging #79 (8d02ce5) into main (840a19e) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
+ Coverage   49.30%   49.32%   +0.01%     
==========================================
  Files          19       19              
  Lines        3235     3236       +1     
==========================================
+ Hits         1595     1596       +1     
  Misses       1469     1469              
  Partials      171      171
Impacted Files Coverage Δ
wrpmeta/metadata.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 840a19e...8d02ce5. Read the comment docs.

Sachin4403 commented 2 years ago

Hello @kristinapathak Could you please merge this PR?

denopink commented 2 years ago

👆 can we merge this @johnabass