xmidt-org / wrp-go

go implementation of the Web Routing Protocol
Apache License 2.0
4 stars 7 forks source link

Fix the tests since 'qos' field got added but apparently lost in a me… #90

Closed schmidtw closed 2 years ago

schmidtw commented 2 years ago

…rge.

codecov[bot] commented 2 years ago

Codecov Report

Merging #90 (bc6e6dc) into main (1bdb169) will decrease coverage by 0.02%. The diff coverage is 23.94%.

@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
- Coverage   50.16%   50.14%   -0.03%     
==========================================
  Files          21       23       +2     
  Lines        3827     3883      +56     
==========================================
+ Hits         1920     1947      +27     
- Misses       1736     1760      +24     
- Partials      171      176       +5     
Flag Coverage Δ
unittests 50.14% <23.94%> (-0.03%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
messages.go 96.77% <ø> (ø)
messages_codec.go 34.48% <20.17%> (+0.03%) :arrow_up:
qoslevel_string.go 40.00% <40.00%> (ø)
qos.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 373d6d6...bc6e6dc. Read the comment docs.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

schmidtw commented 2 years ago

I'm merging without reviews to get the tests fixed, but added the reviewers for visibility for them.