xmidt-org / xmidt

Highly scalable pipes for communicating with devices all over the place.
Apache License 2.0
17 stars 19 forks source link

Guide to common server configuration #22

Closed joe94 closed 4 years ago

joe94 commented 4 years ago

Today, each server repo provides a sample configuration file with useful comments on each config. While this works, it creates a lot of repeated effort and takes away focus from configuration values that are specific to the service.

One approach to

kristinapathak commented 4 years ago

My understanding of the goal of the documentation of the yaml is that when someone installs the rpm, it contains the yaml with this documentation so they automatically get this. I'm not a big fan of splitting the documentation up into separate yamls as I think that increases confusion even if it decreases duplication. Also, there are some configuration values that are used by multiple services but not all of them so there aren't just two buckets - "universal" and "server specific".

Moving blocks of configuration around in the current files sounds fine to me; the current system I'm aware of is the same order of general xmidt stuff at the top and server specific stuff at the bottom. Flipping it seems fine. Personally I just want to have an order I expect.

joe94 commented 4 years ago

@kristinaspring that's good you brought up RPMs to the picture ...

Considering that, I'm leaning to only implement the flipping orders portion then.

And just FYI: I was taking a the perspective of someone taking the opensource project and creating the comcast specific deployment configs for the new themis as an example.

@johnabass, thoughts?

joe94 commented 4 years ago

It might be better to continue the current system until we get learn more about the experience of teams that use our product from the opensource.