xmikos / fdroiddata

Eutopia.cz F-Droid Repository
GNU Affero General Public License v3.0
40 stars 8 forks source link

LibreSignal #13

Closed mimi89999 closed 8 years ago

mimi89999 commented 8 years ago

Will you use my fork: https://github.com/LibreSignal/LibreSignal in your experimental repo?

xmikos commented 8 years ago

Hi, what changes are you planning in comparison with JavaJens fork? Is there some roadmap or TODO list? Are you open for patches adding new features (like my patch for enabling WebSocket-only mode at runtime instead of compile-time)?

mimi89999 commented 8 years ago

The current roadmap is to get LibreSignal accepted in the official F-Droid repo and to pull updates from upstream. I removed Location and the ability to use GCM from LibreSignal because they needed non-free libraries. The app is WebSocket-only.

Are you open for patches adding new features

Yes under the condition that they don't require non-free libraries.

like my patch for enabling WebSocket-only mode at runtime instead of compile-time

I think your patch should be mered in JavaJens fork, but not here since there is no GCM support...

xmikos commented 8 years ago

@mimi89999 I have reviewed your changes and it seems good. But I don't like removing Location sharing support... maybe it could be replaced by some shim from microG project? Did you look into this possibility?

mimi89999 commented 8 years ago

I will look into that later...

mimi89999 commented 8 years ago

Implementing completly free/libre location support won't be easy and I don't think it's so important for me to work on it, but I'm open to PR.

mimi89999 commented 8 years ago

https://github.com/LibreSignal/LibreSignal/issues/11

mimi89999 commented 8 years ago

@xmikos Have you received my reply to your email?

mimi89999 commented 8 years ago

Also, I will change the package name: https://github.com/LibreSignal/LibreSignal/issues/12

xmikos commented 8 years ago

Finally done :-)

SecUpwN commented 8 years ago

Thanks for the wonderful collaboration @mimi89999 and @xmikos! :+1:

mimi89999 commented 8 years ago

LibreSignal is not in the F-Droid archive repo because they had problems building it...