xmlresolver / xmlresolvercs

A C# implementation of the XML Resolver
Other
4 stars 3 forks source link

Fix issues #3, #10, and #11 (not #9, as the commit message says) #12

Closed ndw closed 2 years ago

ndw commented 2 years ago

Fix additional catalogs

Make sure that the ADDITIONAL_CATALOGS feature works.

Close #3

Fix assembly catalogs

The ASSEMBLY_CATALOG feature implementation was confused. The feature was treated as if it was a string, but in fact it's a list of strings.

  1. Rename the feature ASSEMBLY_CATALOGS (with an "S" on the end)
  2. GetFeature returns a list of strings (as it always did, though this caused an casting error)
  3. SetFeature accepts a single string, which it adds to the assembly catalog list. This is backwards compatible behavior. It also accepts a list of strings, in which case it replaces the entire list. If null is passed, the list is cleared.

Close #10

Catalog loader

Add the archived catalog methods to the interface and rename it to ICatalogLoader.

Close #11

Bump version to 0.3.0

In preparation for a new NuGet package. Breaking changes to interfaces probably mandate a major version change, but I'm giving myself freedom to ignore that as long as the major version is 0.