Update to libxml2 version incorporating code review feedback

xmlsec / python-xmlsec

Python bindings for the XML Security Library.

MIT License

93 stars 97 forks source link

Update to libxml2 version incorporating code review feedback #300

Closed jonathangreen closed 6 months ago

jonathangreen commented 6 months ago

This is a small update to #299 that incorporates the excellent feedback @scoder left on the PR after it was merged. It addresses a couple edge cases where an exception could have been raised and not handled in the original PR.

jonathangreen commented 6 months ago

Thanks @scoder, appreciate you taking the time to review here! I committed those suggested changes.

jonathangreen commented 6 months ago

@jimjag I think this one is ready to go and might be good to get merged before a release.