search

xmlsquad / gsheet-to-xml

Given the url of a Google Sheet, this Symfony Console command fetches the Google Sheet and outputs it in the form of Xml.
Apache License 2.0
2 stars 1 forks source link

Suggest to rename `forikal:gsheet-to-xml` command to `gsheet-to-xml` #17

Open igormukhingmailcom opened 6 years ago

igormukhingmailcom commented 6 years ago

To meet same style...

Igors-MacBook-Pro:xml-authoring-project igor$ bin/console 
Forikal Tools 0.2.1

Usage:
  command [options] [arguments]

Options:
  -h, --help            Display this help message
  -q, --quiet           Do not output any message
  -V, --version         Display this application version
      --ansi            Force ANSI output
      --no-ansi         Disable ANSI output
  -n, --no-interaction  Do not ask any interactive question
  -v|vv|vvv, --verbose  Increase the verbosity of messages: 1 for normal output, 2 for more verbose output and 3 for debug

Available commands:
  capture-lookups        Downloads specified Google Sheet and saves it as a CSV.
  hello-world            Example command
  help                   Displays help for a command
  list                   Lists commands
 forikal
  forikal:gsheet-to-xml  Convert GSheet file to XML                   <---------------
forikal-uk commented 6 years ago

That is a good suggestion. I intend to separate the inventory model from the infrastructural (cli, control) code. So, I might rename with a prefix to indicate that it relates to the Inventory model.

forikal-uk commented 6 years ago

I have renamed the command namespace to 'Inventory' to make it explicit that it works on the 'Inventory' model.

I will be refactoring the whole gsheet-to-xml project to separate the model from the infrastructural code to allow it to be used with other domain models (types of sheet).

See: https://github.com/xmlsquad/gsheet-to-xml/blob/c3aea8c1ce6564bd6d2e54b5a2bd600c46c5e9f0/src/Command/GsheetToXmlCommand.php