search

xmlsquad / gsheet-to-xml

Given the url of a Google Sheet, this Symfony Console command fetches the Google Sheet and outputs it in the form of Xml.
Apache License 2.0
2 stars 1 forks source link

Move spreadsheet rules to domain object #29

Closed forikal-uk closed 5 years ago

forikal-uk commented 5 years ago

Goal

See issue summary

Why

To move domain logic out of the GoogleSpreadsheetReadService and GoogleDriveFolderReadService to make them more reusable.

How

forikal-uk commented 5 years ago

I have moved the ignore rules to the domain object

forikal-uk commented 5 years ago

Add an Interface specifically for GSuiteHandlingSpecifications

This goes into the /Users/x/Documents/Projects/XmlAuthoringSuite/xml-authoring-project/vendor/xmlsquad/xml-authoring-library

forikal-uk commented 5 years ago

Create a default GSuiteHandlingSpecifications class in library for the lazy userland devs

...and to avoid duplication in my own code.

forikal-uk commented 5 years ago

Find the methods that expect GSuiteHandlingSpecificationsInterface:

and inject via ->createGSuiteHandlingSpecifications()

forikal-uk commented 5 years ago

So this is done.