search

xmlsquad / gsheet-to-xml

Given the url of a Google Sheet, this Symfony Console command fetches the Google Sheet and outputs it in the form of Xml.
Apache License 2.0
2 stars 1 forks source link

Feedback for ignored files/tabs #4

Closed zoka123 closed 6 years ago

zoka123 commented 6 years ago

Specification says:

If a Google Sheet's tab is named foo_, then it is assumed to be 'private' and should be explicitly ignored, but it should be noted (in any feedback) that it was ignored.

and

If a file is called foo_, then it is assumed to be 'private' and should be explicitly ignored, but it should be noted (in any feedback) that it was ignored

How should system note the feedback? It can't be message in the output as it would disrupt the XML

forikal-uk commented 6 years ago

I stole that spec from the spec for our validator tool. So, that was me being sloppy. So, I apologise.

You are quite right. It would not be right to output this into the STD_OUT or even the STD_ERR.

In the next phase, we will be writing to files instead of steaming to STD_OUT. When that time comes we will have a channel through which we can report such information if in "verbose mode".

For now, please add some kind of comment and a @todo docblock mention to remind us that, when ignoring /skipping files we could report it when we have the mechanism.

I don't feel good about my answer here. It is a bit 'smelly' and 'alarm bells'. If anyone can slap me and tell me I am not thinking straight then I would be happy to listen. :)

zoka123 commented 6 years ago

I suggest we leave @todo comment and implement feedback console messages once XML is written directly to file instead on STD_OUT.

Then you can pipe the output to some log file and see which tabs are skipped

forikal-uk commented 6 years ago

Thanks.