src-sheet attribute has confusing value when Drive folder is grabbed.

forikal-uk commented 6 years ago

Steps to Recreate

I have been following the Documentation.

I have successfully grabbed a folder of GSheets and streamed them as XML.

See my notes here.

What occurs?

In the resulting Xml that is streamed to the STD_OUT

I note that the Inventory src-sheet attribute is actually defining a Google Folder and not a sheet.

What is expected

Either

the src-sheet attribute should be renamed to reflect that it is the 'target url' for the command that got the xml (maybe src-google-url ), or
the src-sheet should actually specify a Google Sheet url and not a Folder url. Thus making the value match the name.

We will have to have a think about this to see what is better.

forikal-uk commented 6 years ago

@zoka123

I have been testing this (See #6) and I am incredibly pleased. I followed your technical writing of the documentation very easily and got it working almost immediately. So, thanks.

I have spotted one bug, quite minor (see above).

zoka123 commented 6 years ago

I've added PR with updates https://github.com/forikal-uk/gsheet-to-xml/pull/9

xmlsquad / gsheet-to-xml