search

xmlsquad / gsheet-to-xml

Given the url of a Google Sheet, this Symfony Console command fetches the Google Sheet and outputs it in the form of Xml.
Apache License 2.0
3 stars 1 forks source link

Please reflect Sheet name in Xml Attributes too. #8

Closed forikal-uk closed 6 years ago

forikal-uk commented 6 years ago

Steps to recreate

I added some TestFixture files to use as samples to test on.

I ran the gsheet-to-xml command supplying the Drive folder url.

The xml is streamed to a STD_OUT (see it here)

What happens

When I try to compare the resulting Xml with the TestFixture files I find it hard to work out which snippet of Xml related to which File. I notice the Tab names are really handy. I was almost prompted to go and update my TestFixture tab names to reflect the sheet name in them to make my life easier.

What is expected

So, now it would be great if the Xml attribute could, not only, reflect the sheet url, and tab name, but also reflect the Sheet Name (escaped properly for Xml attributes) if possible.

This would make manual testing of the tool against known TestFixture files a bit easier.

forikal-uk commented 6 years ago

@zoka123 I have added a request for improvement to make testing easier.

zoka123 commented 6 years ago

@forikal-uk

I've create PR with improvements https://github.com/forikal-uk/gsheet-to-xml/pull/9

Inventory element now looks like this:

<Product>
    <Inventory src-sheet="File1.xlsx" src-sheet-url="https://docs.google.com/spreadsheets/d/1-3FbTkn7VSbfRmiOgp_IDBBKm4FJ3HVNs9kEf64ZWOQ/" src-tab="Sheet3">

Note that I've added src-sheet with spreadsheet name, src-sheet-url with the spreadsheet URL, keeping src-tab with sheet/tab name.

I think this is now quite descriptive

forikal-uk commented 6 years ago

Thanks. @zoka123 . That is great.