search

xmonad / xmonad-contrib

Contributed modules for xmonad
https://xmonad.org
BSD 3-Clause "New" or "Revised" License
588 stars 274 forks source link

[XMonad.Util.EZConfig] Function key XF86WLAN missing #27

Closed schoettl closed 7 years ago

schoettl commented 8 years ago

The XF86WLAN function key missing in the supported function keys of EZConfig: http://xmonad.org/xmonad-docs/xmonad-contrib/XMonad-Util-EZConfig.html

On my ThinkPad T450s I've got this one to enable/disable wifi. https://wiki.archlinux.org/index.php/Lenovo_ThinkPad_T450s#Function_Keys Edit: There are actually one more unsupported function key:

$ xev | awk -F'[ )]+' '/^KeyPress/ { a[NR+2] } NR in a { printf "%-3s %s\n", $5, $8 }'
246 XF86WLAN
198 XF86AudioMicMute
vrs commented 8 years ago

I think the place to add this would be xmonad-x11? See also: https://github.com/xmonad/X11/issues/21

byorgey commented 8 years ago

Well, it would need to be added in both places.

schoettl commented 8 years ago

So in xmonad/X11#21 there is a script to generate this keys.

Unfortunately there is no X11 header file containing this key (on my computer):

$ grep XF86WLAN  /usr/include/X11/*keysym.h

(no output)

And there is also no file for Lenovo/IBM keysyms :(

What do you think about placing an X11 header file Missingkeysym.h in the repo and use the same script as in #21 (slightly modified) to generate the bindings?

byorgey commented 8 years ago

I think it is in /usr/include/X11/XF86keysym.h as XF86XK_WLAN.

schoettl commented 8 years ago

Oh, you're right! So once someone gets the script for autogeneration to run, this key should get included in EZConfig...

pjones commented 7 years ago

Fixed with xmonad/X11#41