EwmhDesktops: Advertise _NET_WM_STATE_DEMANDS_ATTENTION.

xmonad / xmonad-contrib

Contributed modules for xmonad

https://xmonad.org

BSD 3-Clause "New" or "Revised" License

589 stars 274 forks source link

EwmhDesktops: Advertise _NET_WM_STATE_DEMANDS_ATTENTION. #618

Closed aartamonau closed 3 years ago

aartamonau commented 3 years ago

Description

XMonad.Hooks.UrgencyHook knows how to understand this hint, but it's not advertised as supported via _NET_SUPPORTED. This prevents certain applications (e.g. kitty terminal emulator) from using it.

Checklist

[x] I've read CONTRIBUTING.md
[x] I've considered how to best test these changes (property, unit, manually, ...) and concluded: I ran stack test in xmonad-contrib and verified that with the change kitty terminal emulator sets the hint on bell character.
[x] I updated the CHANGES.md file

geekosaur commented 3 years ago

Hm. @liskin, do we perhaps want this to be conditional on use of UrgencyHook via your new framework?

geekosaur commented 3 years ago

By the way, @aartamonau, it often works better to make a local branch instead of using master when making pull requests, so you can have more than one at a time. This won't break us, but may confuse you if you try to submit any more PRs.

liskin commented 3 years ago

Hm. @liskin, do we perhaps want this to be conditional on use of UrgencyHook via your new framework?

Definitely, yes. The first step in my refactor is going to be moving all the _NET_SUPPORTED stuff to XMonad.Util.EWMH and exporting an API that individual modules can use to advertise their part of EWMH support.

Actually, we already kind of have that a bit with addSupported in EwmhDesktops, it's just not exported and doesn't compose with setSupported reliably.

liskin commented 3 years ago

Thank you! :tada: