ci: Update supported GHC versions

xmonad / xmonad-contrib

Contributed modules for xmonad

https://xmonad.org

BSD 3-Clause "New" or "Revised" License

589 stars 274 forks source link

ci: Update supported GHC versions #694

Closed slotThe closed 2 years ago

slotThe commented 2 years ago

NOTE: I will prepare the same thing for the xmonad repo, but don't want to create too much noise with PRs. After this is rubber-stamped I will just push it directly.

Description

Prefer GHC 8.10.7 to 8.10.4, as versions seem to have stabilised now.
Add support for Stackage LTS 19, which ships with GHC 9.0.2.
Since a new version of 9.2 has been released, prefer 9.2.2 over 9.2.1.

Also, explicitly pass -XCPP to hlint; see 1.

Checklist

[x] I've read CONTRIBUTING.md
[x] I've considered how to best test these changes (property, unit, manually, ...) and concluded: CI passes
[n/a] I updated the CHANGES.md file

liskin commented 2 years ago

I'm a bit confused about why the hlint issue was not a problem before. Can anyone help me understand that? Otherwise this looks all right apart from the one issue in the stack workflow.

slotThe commented 2 years ago

I'm a bit confused about why the hlint issue was not a problem before. Can anyone help me understand that?

It seems like the bug only fires when -XHaskell2010 is passed to hlint (see https://github.com/ndmitchell/hlint/pull/1361). This was not done before, but the haskell-ci version that I built apparently adds it. I suppose another solution would be to remove XHaskell2010 altogether and let hlint figure out what the default extensions are.

liskin commented 2 years ago

It seems like the bug only fires when -XHaskell2010 is passed to hlint (see ndmitchell/hlint#1361). This was not done before, but the haskell-ci version that I built apparently adds it. I suppose another solution would be to remove XHaskell2010 altogether and let hlint figure out what the default extensions are.

Oh, I see. I was looking at the wrong diff. Will give it some more thought once I get back from pub :-)

slotThe commented 2 years ago

@liskin got any insights from the beer? :)

liskin commented 2 years ago

@liskin got any insights from the beer? :)

No real insights. I set a reminder for myself to check/drop the hlint patch in 2 months time (kinda hoped the fix would have been released by now) and forcepushed the stack.yaml fixes. Feel free to proceed with other repos, and sorry for the delay.