Use `mkAbsolutePath` in `doAppend` (XMonad.Prompt.AppendFile)

xmonad / xmonad-contrib

Contributed modules for xmonad

https://xmonad.org

BSD 3-Clause "New" or "Revised" License

588 stars 274 forks source link

Use `mkAbsolutePath` in `doAppend` (XMonad.Prompt.AppendFile) #744

Closed geekosaur closed 2 years ago

geekosaur commented 2 years ago

Description

Enhance mkAbsolutePath to support environment variables, then use it in XMonad.Prompt.AppendFile's doAppend so filespecs like ~/NOTES and $HOME/file.txt are supported.

Checklist

[x] I've read CONTRIBUTING.md
[x] I've considered how to best test these changes (property, unit, manually, ...) and concluded: manually tested in ghci
[ ] I updated the CHANGES.md file

geekosaur commented 2 years ago

Should I add this to CHANGES?
Should I split this in two by the two commits?

geekosaur commented 2 years ago

I actually meant making a separate PR for each commit, as each addresses a different issue.

slotThe commented 2 years ago

Oh right. I don't think that's necessary; I think we tend to think in commits more than PRs anyways

geekosaur commented 2 years ago

That most recent push is just a rebase.