xmonad / xmonad-contrib

Contributed modules for xmonad
https://xmonad.org
BSD 3-Clause "New" or "Revised" License
584 stars 274 forks source link

Remove keys type #761

Closed exorcist365 closed 1 year ago

exorcist365 commented 1 year ago

Description

Include a description for your changes, including the motivation behind them.

Checklist

TheMC47 commented 1 year ago

You're right about the haddock docs looking bad with this type hidden... Not the brightest idea I had.

However, I don't think this type should be exposed here. If we want to expose it, either do it in XMonad.Prelude and replace the occurrences, or, better yet, maybe from core.

slotThe commented 1 year ago

There might also be an argument for just removing this alias. We're only using it in two places, really, so it might just unnecessarily confuse people

exorcist365 commented 1 year ago

I mean... fair.

TheMC47 commented 1 year ago

LGTM, just change the commit message to something more descriptive

slotThe commented 1 year ago

Thanks