search

xmonad / xmonad-contrib

Contributed modules for xmonad
https://xmonad.org
BSD 3-Clause "New" or "Revised" License
584 stars 274 forks source link

Add EWMH configuration to not set _NET_DESKTOP_VIEWPORT #791

Closed pbrisbin closed 1 year ago

pbrisbin commented 1 year ago

This information is picked up by polybar's xworkspaces module and used to re-group the workspaces by monitor. I (and others) find this super confusing, but polybar doesn't not seem open to addressing it.

https://github.com/polybar/polybar/issues/2603

Opting in to the old behavior of not managing this property is one way to work around it instead.

pbrisbin commented 1 year ago

There's some inconsistency as to spacing

Yeah, I was trying to match the surrounding code as best I could. I would certainly not write this this way myself :sweat_smile:

slotThe commented 1 year ago

Thank you! (I just added an entry to CHANGES.md and prettified the link in the Haddocks a bit)

slotThe commented 10 months ago

This is just to note that https://github.com/polybar/polybar/pull/2926 was merged and is now in polybar 3.7.0, so perhaps we can remove this again soon-ish?

liskin commented 10 months ago

Well, seeing the pace of things (related to this issue/PR) being merged and released and picked up by distros, a safe value of "soon-ish" would be like a year or two. 🙂

slotThe commented 10 months ago

… I guess you are right with that :)