xmonad / xmonad-contrib

Contributed modules for xmonad
https://xmonad.org
BSD 3-Clause "New" or "Revised" License
584 stars 274 forks source link

X.U.NamedActions: Do not discard all keybindings in addDescrKeys #796

Closed slotThe closed 1 year ago

slotThe commented 1 year ago

Discarding keybindings may yield unintended behaviour when keybindings are added via combinators, instead of the keys field. This makes the combinators noncommutative, which is very counterintuitive.

Related: https://old.reddit.com/r/xmonad/comments/10g1v1r/deftogglestrutskey_not_working/


This is a PR because I don't use NamedActions and, though I've verified that this doesn't immediately break things with the simplest config, someone else should look at ti


Checklist

slotThe commented 1 year ago

Let's see, then :)