Closed Zawaken closed 11 months ago
FWIW when making a modified version of an existing combinator, the Haskell convention is to append a prime '
to the name. There are several examples already in the module.
Yeah, I saw magnify'
was already used, so not sure what to then call it.
If you have any idea that is better than what I have put here, I would gladly take them. 😄
(If you want, I can also make these changes, and squash everything together nicely; just say so)
Yeah I'd love that @slotThe 😄
Thank you for the contribution! :tada:
Description
Include a description for your changes, including the motivation behind them.
I've added another general combinator to XMonad.Layout.Magnifier, that allows setting up custom size both horizontally and vertically.
magnifyxy
is the new combinator, and the new implementations of magnifiers aremagnifierxy
,magnifierxy'
,magnifierxyOff
, andmagnifierxyOff'
.Not sure if I am 100% on the names of the combinators.
This was mostly done to make it possible to make a
maximizeVertical
that defaults toOn
.Checklist
[x] I've read CONTRIBUTING.md
[x] I've considered how to best test these changes (property, unit, manually, ...) and concluded: The combinators work, and the MagnifyMore+MagnifyLess keybinds still work with magnifierxy.
[x] I updated the
CHANGES.md
file