Open slotThe opened 11 months ago
There's a but that I can't figure out right now: Assuming something like
myLayout = onWorkspace "4" (tall ||| Full) $ Full ||| tall ||| Mirror tall
where
tall = Tall 1 (3/100) (1/2)
one needs to issue five M-SPC
calls to cycle through all layouts, regardless which branch one is on right now (some of those M-SPC
invocations will just not do anything—at least not visibly).
Haven't tried debugging this yet, as its getting late, but perhaps someone else immediately knows what's up.
Is using Choose
internally wise? That's going to add a couple extra mod-space-s and I'm wondering how that interacts with the explicit condition (wouldn't it effectively invert it?).
Also it may be better to leave PerScreen
alone until we decide what's happening with #813.
Supersedes https://github.com/xmonad/xmonad-contrib/pull/582
What I haven't done, yet we probably should (not necessarily in this PR):
RewriteIfMax
,PreScreen
, andPerWorkspace
with this, which would close https://github.com/xmonad/xmonad-contrib/issues/75Provide some QOL functions so that it's easier to write predicates. E.g., I reckon lots of people will want to use a variant ofgets $ find ((t ==) . W.tag) . W.workspaces . windowset
.TODOS:
New module: X.L.ConditionalLayout
Provide conditional variants of 'ModifiedLayout' and 'Choose', so that modifications (specific layouts) are only applied when a particular condition is met.
Co-authored-by: Tomas Janousek tomi@nomi.cz Co-authored-by: Ivan Malison IvanMalison@gmail.com
Description
Include a description for your changes, including the motivation behind them.
Checklist
[x] I've read CONTRIBUTING.md
[x] I've considered how to best test these changes (property, unit, manually, ...) and concluded: cursory testing on my computer yielded the desired results, though someone else should look at this.
[x] I updated the
CHANGES.md
file