Add a new prevCompletionKey to XPConfig, in order to cycle backwards.
Bound to S-<Tab> by default.
Already handle null keystrings (times when only a modifier was
pressed) in handleMain, such that completions aren't cleared
prematurely.
Augment nextComplIndex (now computeComplIndex) with the ability to go
in an arbitrary 1-dimensional direction. As a result, that function,
as well as handleCompletion and handleCompletionMain now take an
additional Direction1D argument.
[x] I've considered how to best test these changes (property, unit,
manually, ...) and concluded: manually confirmed for this to work, but @l29ah should double check
Fixes: https://github.com/xmonad/xmonad-contrib/issues/831
Add a new
prevCompletionKeytoXPConfig, in order to cycle backwards. Bound toS-<Tab>by default.Already handle null keystrings (times when only a modifier was pressed) in
handleMain, such that completions aren't cleared prematurely.Augment
nextComplIndex(nowcomputeComplIndex) with the ability to go in an arbitrary 1-dimensional direction. As a result, that function, as well ashandleCompletionandhandleCompletionMainnow take an additionalDirection1Dargument.Based on: https://github.com/solomon-b/xmonad-contrib/tree/feature/scrolling-prompt-completions
Co-authored-by: Solomon Bothwell ssbothwell@gmail.com
Checklist
[x] I've read CONTRIBUTING.md
[x] I've considered how to best test these changes (property, unit, manually, ...) and concluded: manually confirmed for this to work, but @l29ah should double check
[x] I updated the
CHANGES.mdfile