I went to use the TwoPane layout while trying out xmonad, and immediately ran into the problem that Shrink and Expand were shrinking my windows into negative width, which broke alacritty.
To investigate the problem, I started reading the Layout.hs from xmonad/xmonad, and noticed that the Tall layout applies a min and max to the respective widths:
Applying this same approach to Shrink and Expand in the TwoPane layouts (tested in my own xmonad.hs) resolves this problem for me, but I am a beginner to xmonad and may be misunderstanding something. :blue_heart:
[x] I've considered how to best test these changes (property, unit,
manually, ...) and concluded: writing tests is probably beyond my spare time for now
Description
I went to use the
TwoPane
layout while trying outxmonad
, and immediately ran into the problem thatShrink
andExpand
were shrinking my windows into negative width, which brokealacritty
.To investigate the problem, I started reading the
Layout.hs
fromxmonad/xmonad
, and noticed that theTall
layout applies amin
andmax
to the respective widths:Applying this same approach to
Shrink
andExpand
in theTwoPane
layouts (tested in my ownxmonad.hs
) resolves this problem for me, but I am a beginner toxmonad
and may be misunderstanding something. :blue_heart:Checklist
[x] I've read CONTRIBUTING.md
[x] I've considered how to best test these changes (property, unit, manually, ...) and concluded: writing tests is probably beyond my spare time for now
[ ] I updated the
CHANGES.md
file