xmonad / xmonad-contrib

Contributed modules for xmonad
https://xmonad.org
BSD 3-Clause "New" or "Revised" License
584 stars 274 forks source link

update time to <1.15 #881

Closed geekosaur closed 6 months ago

geekosaur commented 6 months ago

Description

Update bounds of time to allow the new 1.14 release.

Checklist

geekosaur commented 6 months ago

Actually, since time is a bootlib CI is still using 1.12.2. Have to see how to test it locally.

liskin commented 6 months ago

I believe @slotThe did the testing a couple times in the past when I pinged him on IRC after the Packdeps CI failed. Perhaps we should add a note about this to MAINTAINERS.md so we don't need to remember (and also to decrease the bus factor).

We could even make the Packdeps job point us to the relevant piece of documentation to minimise the brain function required to deal with this :-D

slotThe commented 6 months ago

I saw the

build with --constraint='time == 1.14' passed locally

edit and figured that the local tests ran through.

We could even make the Packdeps job point us to the relevant piece of documentation to minimise the brain function required to deal with this :-D

We could also look into using https://github.com/nomeata/cabal-plan-bounds to generate version constraints automatically, or https://github.com/nomeata/cabal-force-upper-bound to force CI to use the upper bound of a package

geekosaur commented 6 months ago

edit and figured that the local tests ran through.

They did, and I updated to show it. Should I have deleted that comment afterward? (or edited it, I guess)

The main complication is that my setup is complicated, so building just xmonad-contrib is harder than building the whole stack and slipping in a constraint.