X.A.WindowBringer: Add copyMenu - Githubissues

xmonad / xmonad-contrib

Contributed modules for xmonad

https://xmonad.org

BSD 3-Clause "New" or "Revised" License

579 stars 271 forks source link

X.A.WindowBringer: Add copyMenu #895

Closed thalting closed 3 weeks ago

thalting commented 3 weeks ago

XMonad.Prompt.WindowBringer (copyMenu)

A convenient way to copy a window to the current workspace.

Checklist

[x] I've read CONTRIBUTING.md
[x] I've considered how to best test these changes (property, unit, manually, ...) and concluded: XXX
[x] I updated the CHANGES.md file

geekosaur commented 3 weeks ago

Looks like you forgot to include your changes to xmonad-contrib.cabal?

thalting commented 3 weeks ago

Looks like you forgot to include your changes to xmonad-contrib.cabal?

What changes? Wouldn't that be for new modules?

geekosaur commented 3 weeks ago

Oh, I see, you don't run the test suite. The problem is that the test suite tests XMonad.Actions.WindowBringer, so its new dependencies need to be added to its other-modules.

geekosaur commented 3 weeks ago

Okay, that looks better. Although now that I look, I don't see the test suite actually using WindowBringer at all, so possibly it needs to be removed (not your problem, it's future work and I'll have to check for any other dependencies the test suite isn't using).

geekosaur commented 3 weeks ago

Thanks!

geekosaur commented 3 weeks ago

Looks like something is using it after all…