xmonad / xmonad-contrib

Contributed modules for xmonad
https://xmonad.org
BSD 3-Clause "New" or "Revised" License
589 stars 274 forks source link

X.A.WindowNavigation: better handling of floating windows and Full layout #896

Closed Rogach closed 3 months ago

Rogach commented 4 months ago

Description

Previous version of WindowNavigation just got "stuck" on floating windows, switching back and forth between floating window and tiled window underneath. This was because "magic point" was left in the same position and thus next navigation commands selected the same windows over and over again. Now the "magic point" is moved around such that it doesn't overlap with the previously selected window, and there are more complicated rules to make navigation between floating and tiled windows more natural.

The original behavior of navigating between tiled windows is preserved almost precisely (the tree-like layouts - which should be overwhelmingly the most popular ones - will have exactly the same behavior, the only differences might be in some convoluted custom layouts).

Previous version of WindowNavigation also prevented switching windows using focusUp/focusDown when in Full layout. Now there's a special case that handles such situations.

Checklist

geekosaur commented 4 months ago

I'm going to wait a few days for one of the other maintainers to look at it, but as they're often unavailable I won't wait too long.

slotThe commented 4 months ago

I'm going to wait a few days for one of the other maintainers to look at it, but as they're often unavailable I won't wait too long.

FWIW I definitely plan to look at this in the coming days

slotThe commented 3 months ago

Thanks!