xmos / ai_tools

AI applications and tools
Other
25 stars 10 forks source link

Build using the non-os specific version of MacOSX.sdk #230

Closed keithm-xmos closed 4 years ago

keithm-xmos commented 4 years ago

We currently require installing MacOSX10.13.sdk in order to build the Interpreter Python bindings on macOS. Developers should be able to build using a non-os specific version of the SDK (provided it is compatible).

This is a minor change to the CMakeLists.txt file(s). Simply replace:

set(CMAKE_OSX_SYSROOT /Library/Developer/CommandLineTools/SDKs/MacOSX10.13.sdk)

with

set(CMAKE_OSX_SYSROOT /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk)

However, we will need a way to build a distribution for the minimally supported macOS version (currently 10.13 High Sierra). Ideally this will be implement in the CI system.

keithm-xmos commented 4 years ago

Closed by https://github.com/xmos/ai_tools/pull/234